From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Date: Fri, 1 Mar 2024 22:45:28 +0100 Subject: [PATCH 15/18] serial: pch: Don't disable interrupts while acquiring lock in ISR. The interrupt service routine is always invoked with disabled interrupts. Remove the _irqsave() from the locking functions in the interrupts service routine/ pch_uart_interrupt(). Link: https://lore.kernel.org/r/20240301215246.891055-16-bigeasy@linutronix.de Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- drivers/tty/serial/pch_uart.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Index: linux-6.8.2-rt10/drivers/tty/serial/pch_uart.c =================================================================== @ linux-6.8.2-rt10/drivers/tty/serial/pch_uart.c:1013 @ static irqreturn_t pch_uart_interrupt(in u8 lsr; int ret = 0; unsigned char iid; - unsigned long flags; int next = 1; u8 msr; - spin_lock_irqsave(&priv->lock, flags); + spin_lock(&priv->lock); handled = 0; while (next) { iid = pch_uart_hal_get_iid(priv); @ linux-6.8.2-rt10/drivers/tty/serial/pch_uart.c:1076 @ static irqreturn_t pch_uart_interrupt(in handled |= (unsigned int)ret; } - spin_unlock_irqrestore(&priv->lock, flags); + spin_unlock(&priv->lock); return IRQ_RETVAL(handled); }