Return-Path: <linux-rt-users-owner@vger.kernel.org>
Received: from rack3slot8.osadl.org (rack3slot8.osadl.org [127.0.0.1])
by rack3slot8.osadl.org (8.13.8/8.13.8/CE-2010120801) with ESMTP id r1DGI7gW001132
for <ce@thllin.ceag.ch>; Wed, 13 Feb 2013 17:18:07 +0100
Received: from toro.web-alm.net (uucp@localhost)
by rack3slot8.osadl.org (8.13.8/8.13.8/Submit) with bsmtp id r1DGI6un001130
for ce@mailgate.computer-experts.de; Wed, 13 Feb 2013 17:18:06 +0100
Received: from www.osadl.org (www.osadl.org [62.245.132.105])
by toro.web-alm.net (8.12.11.20060308/8.12.11/Web-Alm-2003112001) with ESMTP id r1DGHD8V009683
for <ce@ceag.ch>; Wed, 13 Feb 2013 17:17:13 +0100
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
by www.osadl.org (8.13.8/8.13.8/OSADL-2007092901) with ESMTP id r1DGHAET025554
for <Carsten.Emde@osadl.org>; Wed, 13 Feb 2013 17:17:10 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S934310Ab3BMQNv (ORCPT <rfc822;Carsten.Emde@osadl.org>);
Wed, 13 Feb 2013 11:13:51 -0500
Received: from www.linutronix.de ([62.245.132.108]:59733 "EHLO
Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S934345Ab3BMQNR (ORCPT
<rfc822;linux-rt-users@vger.kernel.org>);
Wed, 13 Feb 2013 11:13:17 -0500
Received: from localhost ([127.0.0.1] helo=localhost.localdomain)
by Galois.linutronix.de with esmtp (Exim 4.72)
(envelope-from <bigeasy@linutronix.de>)
id 1U5exQ-0005iT-Ac; Wed, 13 Feb 2013 17:13:16 +0100
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
Carsten Emde <C.Emde@osadl.org>, Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH 08/16] net: Use local_bh_disable in netif_rx_ni()
Date: Wed, 13 Feb 2013 17:12:03 +0100
Message-Id: <1360771932-27150-9-git-send-email-bigeasy@linutronix.de>
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1360771932-27150-1-git-send-email-bigeasy@linutronix.de>
References: <1360771932-27150-1-git-send-email-bigeasy@linutronix.de>
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-rt-users-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-rt-users.vger.kernel.org>
X-Mailing-List: linux-rt-users@vger.kernel.org
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on rack3slot8.osadl.org
X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on rack3slot8.osadl.org
X-Virus-Status: Clean
From: Thomas Gleixner <tglx@linutronix.de>
This code triggers the new WARN in __raise_softirq_irqsoff() though it
actually looks at the softirq pending bit and calls into the softirq
code, but that fits not well with the context related softirq model of
RT. It's correct on mainline though, but going through
local_bh_disable/enable here is not going to hurt badly.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
net/core/dev.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Index: linux-3.2.35-rt53/net/core/dev.c
===================================================================
@ linux-3.2.35-rt53/net/core/dev.c:3036 @ int netif_rx_ni(struct sk_buff *skb)
{
int err;
- migrate_disable();
+ local_bh_disable();
err = netif_rx(skb);
- if (local_softirq_pending())
- thread_do_softirq();
- migrate_enable();
+ local_bh_enable();
return err;
}