From 1535f668a316358d433902315c01342919bd79f5 Mon Sep 17 00:00:00 2001 From: Sebastian Andrzej Siewior Date: Fri, 11 Feb 2022 19:14:57 +0100 Subject: [PATCH 162/166] misc: hi6421-spmi-pmic: Use generic_handle_irq_safe(). generic_handle_irq() is invoked from a regular interrupt service routine. This handler will become a forced-threaded handler on PREEMPT_RT and will be invoked with enabled interrupts. The generic_handle_irq() must be invoked with disabled interrupts in order to avoid deadlocks. Instead of manually disabling interrupts before invoking use generic_handle_irq_safe() which can be invoked with enabled and disabled interrupts. Signed-off-by: Sebastian Andrzej Siewior Link: https://lore.kernel.org/r/20220211181500.1856198-5-bigeasy@linutronix.de (cherry picked from commit 87ebe41b420c6163c9cb76ac25ec02333473ff87) Signed-off-by: Clark Williams --- drivers/misc/hi6421v600-irq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux-5.15.32-rt39/drivers/misc/hi6421v600-irq.c =================================================================== --- linux-5.15.32-rt39.orig/drivers/misc/hi6421v600-irq.c +++ linux-5.15.32-rt39/drivers/misc/hi6421v600-irq.c @@ -118,8 +118,8 @@ static irqreturn_t hi6421v600_irq_handle * If both powerkey down and up IRQs are received, * handle them at the right order */ - generic_handle_irq(priv->irqs[POWERKEY_DOWN]); - generic_handle_irq(priv->irqs[POWERKEY_UP]); + generic_handle_irq_safe(priv->irqs[POWERKEY_DOWN]); + generic_handle_irq_safe(priv->irqs[POWERKEY_UP]); pending &= ~HISI_IRQ_POWERKEY_UP_DOWN; } @@ -127,7 +127,7 @@ static irqreturn_t hi6421v600_irq_handle continue; for_each_set_bit(offset, &pending, BITS_PER_BYTE) { - generic_handle_irq(priv->irqs[offset + i * BITS_PER_BYTE]); + generic_handle_irq_safe(priv->irqs[offset + i * BITS_PER_BYTE]); } }